Ticket #84 (closed defect: fixed)

Opened 2 years ago

Last modified 1 year ago

[PATCH] FileMerge on working copy fails with Subversion 1.4

Reported by: robbie@prelab.net Assigned to: dom
Priority: critical Milestone:
Component: Working Copy Browser Version:
Keywords: Cc:

Description

After upgrading to Subversion 1.4, using "FileMerge?" on a working copy seemingly randomly fails -- FileMerge? will sometimes not launch or display a dialog complaining that it cannot compare the files. The problem seems to stem from a change in the handling of the tmp copy that svn diff occasisonaly provides instead of the actual local file. The tmp files are now placed in the system tmp directory and are formatted as so:

svndiff.tmp
svndiff.2.tmp
svndiff.3.tmp
...

This causes the filename mangling svndiff.sh performs to get the path to the actual working copy file to fail.

I've produced a patch against the svnX trunk (r37), that I seems to fix this problem, as well as a cosmetic issue with the extension added to svnx-opendiff tmp files.

I think the patch should also fallback seamlessly to the Subversion 1.3 behaviour, but I have not be able to test this locally due to the Subversion 1.3 -> 1.4 repository format changes.

% uname -a
Darwin mame.local 8.8.0 Darwin Kernel Version 8.8.0: Fri Sep  8 17:18:57 PDT 2006; root:xnu-792.12.6.obj~1/RELEASE_PPC Power Macintosh powerpc

% svn --version                                                                
svn, version 1.4.2 (r22196)
   compiled Nov 15 2006, 03:10:50

% svn info svnx/trunk
...
Revision: 37
...

Attachments

svndiff.sh-patch (0.8 kB) - added by robbie@prelab.net on 11/15/06 21:50:33.

Change History

11/15/06 21:50:33 changed by robbie@prelab.net

  • attachment svndiff.sh-patch added.

03/14/07 08:35:49 changed by ben@nbn.ac.za

Fixes mine, thanks a lot. I had a similar problem, looked like the filenames given to filemerge were wrong.

I checked out the trunk (revision 52), applied the patch, did a clean build and it works nicely. I am using svn version 1.4.3.

And thanks to the svnX guys who make it easy to just build from XCode.

Cheers Benjamin

06/10/07 14:08:29 changed by dom

  • status changed from new to closed.
  • resolution set to fixed.

Add/Change #84 ([PATCH] FileMerge on working copy fails with Subversion 1.4)




Change Properties
Action